-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 162 build docker image in ci #716
Issue 162 build docker image in ci #716
Conversation
As ran into issues during the build process, I opened another PR to enable the docker build with the bash script. |
This seems to be working (https://github.com/paolorechia/arrow-ballista/actions/runs/4518250344), but depends on merging first the PR: #718 |
This PR is very useful for the guys who want to give a try the Ballista with K8s. |
I approved 718, looks like it has some merge conflicts now. I assume that will fix the build for this. Sorry I've been busy with other things and not following closely. |
@avantgardnerio thanks for the review! |
@avantgardnerio it seems like merged here: Is it still broken? Should I fix the merge conflicts so we can try with the NVM build? |
For whatever reason, github is not giving me the ability to trigger this build. I'd suggest rebasing it onto main if that hasn't been done already or pushing an empty commit. |
@avantgardnerio sorry, I forgot to update the branch. I did it now and it seems to pass. |
Which issue does this PR close?
Closes #162
Rationale for this change
Prevent stale/broken builds in the main branch.
What changes are included in this PR?
New CI workflow that runs the
./dev/build-ballista-docker.sh
script on Pull Request trigger.Are there any user-facing changes?
No
Example run: https://github.com/paolorechia/arrow-ballista/actions/runs/4517673072/jobs/7957036021#step:3:2264