Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 162 build docker image in ci #716

Merged

Conversation

paolorechia
Copy link
Contributor

Which issue does this PR close?

Closes #162

Rationale for this change

Prevent stale/broken builds in the main branch.

What changes are included in this PR?

New CI workflow that runs the ./dev/build-ballista-docker.sh script on Pull Request trigger.

Are there any user-facing changes?

No

Example run: https://github.com/paolorechia/arrow-ballista/actions/runs/4517673072/jobs/7957036021#step:3:2264

@paolorechia
Copy link
Contributor Author

As ran into issues during the build process, I opened another PR to enable the docker build with the bash script.

@paolorechia
Copy link
Contributor Author

This seems to be working (https://github.com/paolorechia/arrow-ballista/actions/runs/4518250344), but depends on merging first the PR: #718

@paolorechia paolorechia marked this pull request as ready for review March 25, 2023 09:05
@xin-hao-awx
Copy link

This PR is very useful for the guys who want to give a try the Ballista with K8s.
@andygrove can you have a look?

@avantgardnerio
Copy link
Contributor

I approved 718, looks like it has some merge conflicts now. I assume that will fix the build for this. Sorry I've been busy with other things and not following closely.

@paolorechia
Copy link
Contributor Author

@avantgardnerio thanks for the review!
I think another PR was merged to fix the docker build, would you be able to re-run the build pipeline and see if it passes now?

@paolorechia
Copy link
Contributor Author

paolorechia commented Jun 7, 2023

@avantgardnerio it seems like merged here:

#794

Is it still broken? Should I fix the merge conflicts so we can try with the NVM build?

@avantgardnerio
Copy link
Contributor

Is it still broken?

For whatever reason, github is not giving me the ability to trigger this build. I'd suggest rebasing it onto main if that hasn't been done already or pushing an empty commit.

@paolorechia
Copy link
Contributor Author

@avantgardnerio sorry, I forgot to update the branch. I did it now and it seems to pass.

@avantgardnerio avantgardnerio merged commit 1691457 into apache:main Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Docker images in CI
3 participants