Add grpc service of cleaning up job shuffle data for the scheduler to make it able to be triggered by client explicitly #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yahoNanJing Is it possible to make this PR independent of #472 so that it can be reviewed separately? |
|
Hi @andygrove, there's some code depending on #472. Better to deal with the #472 first. I'll mark this PR as draft. |
…e data be cleaned up to be triggered by client explicitly
yahoNanJing
force-pushed
the
issue-458
branch
from
6f03e7c to
e74d32b
Compare
andygrove
reviewed
Nov 3, 2022
Comment on lines
+557
to
+559
| let msg = format!("Get query stage event loop error due to {:?}", e); | ||
| error!("{}", msg); | ||
| Status::internal(msg) |
There was a problem hiding this comment.
minor nit: we could introduce a function to create these Status messages to avoid duplicating this block of code
andygrove
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
LGTM. Thanks @yahoNanJing. We may want to expose this from the REST API as well in the future so that we can invoke this from the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #458 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?