Add support for Tableau #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avantgardnerio
force-pushed
the
bg_table_types
branch
from
2b386e3
to
5515704
Compare
|
@andygrove I don't know who other than you is tracking FlightSQL support to review this. |
andygrove
reviewed
Oct 28, 2022
Comment on lines
+336
to
+337
| let schema_bytes = self.schema_to_arrow(Arc::new(arrow_schema))?; | ||
| Ok(schema_bytes) |
There was a problem hiding this comment.
looks like it can be simplified to:
Suggested change
| let schema_bytes = self.schema_to_arrow(Arc::new(arrow_schema))?; | |
| Ok(schema_bytes) | |
| self.schema_to_arrow(Arc::new(arrow_schema)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #428.
Rationale for this change
Explained in the issue.
What changes are included in this PR?
Added two FlightSQL handlers necessary for Tableau (and most likely others).
Are there any user-facing changes?
More analytics tools should work.