Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local shuffle reader in containerized environments and some impro… #399

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

Ted-Jiang
Copy link
Member

…vements.

Which issue does this PR close?

Closes #356.

Rationale for this change

  1. support containerized environments
  2. Modify Error type for scheduler retry task
  3. Make local shuffle files read serially for better memory control

What changes are included in this PR?

Are there any user-facing changes?

Copy link
Member Author

@Ted-Jiang Ted-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove @yahoNanJing @mingmwang Test with tpch-1g query1 in local mac, no error no performance downgrade.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ted-Jiang! I don't have an environment to fully test this but I ran this with docker compose and saw no regressions in performance

@andygrove andygrove merged commit 794dd95 into apache:master Oct 21, 2022
Copy link
Contributor

@yahoNanJing yahoNanJing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use local shuffle reader in containerized environments
3 participants