Make the scheduler event loop buffer size configurable #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
Hi @thinkharderdev and @andygrove, could you help review this PR? |
yahoNanJing
force-pushed
the
issue-397
branch
from
a2454cc
to
eae26f1
Compare
yahoNanJing
requested review from
Dandandan
and removed request for
thinkharderdev
andygrove
reviewed
Oct 21, 2022
ballista/scheduler/src/standalone.rs
Outdated
| @@ -38,6 +38,7 @@ pub async fn new_standalone_scheduler() -> Result<SocketAddr> { | |||
| "localhost:50050".to_owned(), | |||
| Arc::new(client), | |||
| BallistaCodec::default(), | |||
| 100000, | |||
There was a problem hiding this comment.
Is it intentional to use 100,000 here and not 10,000 like other places?
There was a problem hiding this comment.
It's not intentional. It's better to set it to be the same as other places. I'll change it.
yahoNanJing
force-pushed
the
issue-397
branch
from
eae26f1
to
cde048f
Compare
|
For production usage, we set the buffer size to be one million to avoid blocking large queries with tens of thousands tasks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #397.
Rationale for this change
Since the channel in the event loop is a bounded one, sometimes when there're many events produced in a short time, it will block the caller when sending events to the channel. If the buffer size is not larger enough, it will downgrade the performance, especially in a high throughput system.
What changes are included in this PR?
Are there any user-facing changes?