Add RoundRobinLocal slots policy for caching executor data to avoid seld persistency #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @thinkharderdev and @andygrove, could you help review this PR? |
18 tasks
yahoNanJing
force-pushed
the
issue-132
branch
from
27d8422
to
4833e1f
Compare
yahoNanJing
requested review from
Dandandan
and removed request for
thinkharderdev
yahoNanJing
force-pushed
the
issue-132
branch
from
4833e1f
to
623c42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #132.
Rationale for this change
When running ballista with single scheduler, there's no need to persist the executor data to the backend sled for every slots change. We can just cache the executor data in memory for efficiency.
What changes are included in this PR?
RoundRobinLocal is added for the slots policy.
Are there any user-facing changes?