Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified the log level configuration behavior #386

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

r4ntix
Copy link
Contributor

@r4ntix r4ntix commented Oct 18, 2022

Which issue does this PR close?

Closes #385

Rationale for this change

See #385

What changes are included in this PR?

Modify file and stdout log level settings code.

Are there any user-facing changes?

Use RUST_LOG env first, if empty, use the --log-level-setting parameter

Use RUST_LOG env first, if empty, use the --log-level-setting parameter
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dandandan Dandandan merged commit 8d83fa2 into apache:master Oct 18, 2022
@r4ntix r4ntix deleted the issues-385 branch March 18, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stdout and file log level settings are inconsistent
3 participants