Enable more benchmark serde tests #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Oct 9, 2022
| @@ -1500,20 +1500,6 @@ mod tests { | |||
| // test logical plan round trip | |||
| let plans = create_logical_plans(&ctx, n)?; | |||
| for plan in plans { | |||
| let proto: datafusion_proto::protobuf::LogicalPlanNode = | |||
There was a problem hiding this comment.
We cant do serde on unoptimized plans because serde does not support subqueries yet
avantgardnerio
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
Tying to prevent any more regressions
What changes are included in this PR?
More tests
Are there any user-facing changes?