Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #306 .
Rationale for this change
As per #306
What changes are included in this PR?
A new component for the stages metrics and the necessary glue code.
Are there any user-facing changes?
Yes, the job id can now be clicked and a modal window appears.
@andygrove -- the initial issue was mentioning that once a job id is clicked, a new window will open. I am new to React and after spending some hours trying to figure out how to use
react-router
without much success, I resorted to using themodal
option. This allows us to keep the look & feel that we have with the graph view. Of course, happy to change to opening in a new window if that's what's better (which might be... depending on what UI features will be needed and how they will be implemented)