Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show job stages metrics #323

Conversation

onthebridgetonowhere
Copy link
Contributor

@onthebridgetonowhere onthebridgetonowhere commented Oct 6, 2022

Which issue does this PR close?

Closes #306 .

Rationale for this change

As per #306

What changes are included in this PR?

A new component for the stages metrics and the necessary glue code.

Are there any user-facing changes?

Yes, the job id can now be clicked and a modal window appears.

@andygrove -- the initial issue was mentioning that once a job id is clicked, a new window will open. I am new to React and after spending some hours trying to figure out how to use react-router without much success, I resorted to using the modal option. This allows us to keep the look & feel that we have with the graph view. Of course, happy to change to opening in a new window if that's what's better (which might be... depending on what UI features will be needed and how they will be implemented)

image

@onthebridgetonowhere onthebridgetonowhere marked this pull request as ready for review October 6, 2022 05:38
@onthebridgetonowhere onthebridgetonowhere changed the title Show list of queries metrics pr306 Show list of queries metrics Oct 6, 2022
@onthebridgetonowhere onthebridgetonowhere changed the title Show list of queries metrics Show list of job stages metrics Oct 6, 2022
@onthebridgetonowhere onthebridgetonowhere changed the title Show list of job stages metrics Show job stages metrics Oct 6, 2022
@andygrove
Copy link
Member

andygrove commented Oct 6, 2022

Thanks @onthebridgetonowhere. This looks great. I am new to react as well and am planning on starting a course soon but have not had the chance yet.

I think this is a great start (and should be merged once I have time to review/test), but ultimately I think we want to have the main view change from the job list to the query stage list when the user clicks on a query, with a link to go back to the query list somehow.

I imagine that the code in App would like something like this, but again, I have no real understanding yet of react and how things like this are normally done.

if (currentJobId != null) {
  <Box>
    // query stage list
  </Box>
} else {
  <Box>
    // job list
  </Box>
}

@onthebridgetonowhere
Copy link
Contributor Author

Thanks for the feedback! If I find some time in the weekend, I'll see if can try some improvements.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this locally. Looks great. Thanks @onthebridgetonowhere.

@andygrove andygrove merged commit 42e9617 into apache:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Show list of query stages with metrics
2 participants