Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helm chart #322

Merged
merged 12 commits into from
Oct 10, 2022
Merged

Add helm chart #322

merged 12 commits into from
Oct 10, 2022

Conversation

avantgardnerio
Copy link
Contributor

Which issue does this PR close?

Closes #321.

Rationale for this change

Described in the issue.

What changes are included in this PR?

A Helm chart.

Are there any user-facing changes?

They will be able to deploy a Ballista cluster with a single command.

@andygrove
Copy link
Member

Thanks @avantgardnerio. I will review this over the weekend. It would be helpful if you could add brief instructions in the user guide on how to deploy Ballista with Helm. That will make the review go quicker ... I haven't used helm in several years.

@andygrove andygrove self-requested a review October 6, 2022 20:25
helm/README.md Outdated
## Prerequisites

```shell
sudo apt install kubectl docker.io docker-compose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this on Ubuntu 20.04.4 LTS and got:

$ sudo apt install kubectl docker.io docker-compose
[sudo] password for andy: 
Reading package lists... Done
Building dependency tree       
Reading state information... Done

No apt package "kubectl", but there is a snap with that name.
Try "snap install kubectl"

E: Unable to locate package kubectl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just document this of course.

## Build

```shell
dev/build-ballista-docker.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails for me with:

ERROR: Version in "./docker-compose.yml" is unsupported. You might be seeing this error because you're using the wrong Compose file version. Either specify a supported version (e.g "2.2" or "3.3") and place your service definitions under the `services` key, or omit the `version` key and place your service definitions at the root of the file to use version 1.

Maybe we can downgrade to 3.3 unless there are specific features we need from newer versions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is a wider discussion we should have about what minimum versions of different operations systems we plan on supporting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR to downgrade to version 3.3 - #329

including all the major cloud providers.
For the purposes of this documentation, we will use Kubernetes-in-Docker (kind) to install locally.

## Prerequisites
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to install Helm as well. I used sudo snap install helm --classic

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works really well. Thanks, @avantgardnerio!

I left some suggestions for the user guide content.

@andygrove andygrove merged commit 6b99780 into apache:master Oct 10, 2022
@avantgardnerio avantgardnerio deleted the bg_helm branch October 17, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Helm Chart
2 participants