Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes 101 and address multiple TODOs inside the codebase.
Rationale for this change
If a large number of states undergo updates, using
RwLock
for the scheduler's in-memory states at the global level will reduce the overall performance. Additionally, some state updates are not atomic and were listed as TODOs. The modifications in this PR makes concurrency more efficient during heavily loaded in-memory updates and more reliable during state persistence.What changes are included in this PR?
Changed
RwLock<HashMap<K, V>>
into aDashMap
. The dashmap crate provides an implementation of a more sophisticated, high-performance concurrent hash map. For reference, DashMap stats areNow performing atomic transactions on
TaskManager
andExecuterManager
, resolvingTODO
s.trait StateBackendClient
, converted methodput_txn
to a more generalapply_txn
.Are there any user-facing changes?
No