Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify job name and have it show in the job listing page in the UI #312

Merged
merged 8 commits into from
Oct 3, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 2, 2022

Which issue does this PR close?

Closes #277

Rationale for this change

Easier to find my jobs now:

query-names

What changes are included in this PR?

Users can set the ballista.job.name config in their context and that name appears in UI.

Are there any user-facing changes?

@andygrove andygrove changed the title Add optional job name Add ability to specify job name and have it show in the job listing page in the UI Oct 2, 2022
@andygrove andygrove marked this pull request as ready for review October 2, 2022 22:17
@andygrove
Copy link
Member Author

@thinkharderdev @yahoNanJing @avantgardnerio I have a few small UI PRs open, including this one. Could you please review when you get a chance?

Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the overhead of handling conditionals in Rust, I'd opt to just have the absence of a job_name be represented by an empty String, but it's not a huge deal.

@andygrove
Copy link
Member Author

Thanks for the review @avantgardnerio

@andygrove andygrove merged commit 78ed511 into apache:master Oct 3, 2022
@andygrove andygrove deleted the job-app-name branch October 3, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Add ability to specify job name and have it show in the job listing page in the UI
2 participants