[UI] Use tabbed pane with Queries and Executors tabs #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KenSuenobu @onthebridgetonowhere Could you review this PR when you get a chance? |
ballista/ui/scheduler/src/App.tsx
Outdated
| return ( | ||
| <Box> | ||
| <Grid minH="100vh"> | ||
| <VStack alignItems={"flex-start"} spacing={0} width={"100%"}> | ||
| <Header schedulerState={schedulerState} /> | ||
| <Summary schedulerState={schedulerState} /> | ||
| <QueriesList queries={jobs} /> | ||
| <Tabs> |
There was a problem hiding this comment.
We probably want to have here: <Tabs width={"100%"}>
onthebridgetonowhere
suggested changes
Oct 2, 2022
| }) => { | ||
| return ( | ||
| <Box flex={1}> | ||
| <DataTable maxW={960} columns={columns} data={nodes} pageSize={4} /> | ||
| <DataTable maxW={960} columns={columns} data={executors} pageSize={4} /> |
There was a problem hiding this comment.
The maxW property is not really useful, unless we need this width size restriction. Removing it makes the table look better.
@andygrove it looks great. I have only two comments regarding look&feel, see above. |
|
Thanks for the review @onthebridgetonowhere. I addressed those two points and it looks much better now. |
onthebridgetonowhere
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
The list of executors could be very large so it does not make sense to show in the header.
What changes are included in this PR?
Jobs Tab
Executors Tab
Are there any user-facing changes?