Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST API to get query stages #305

Merged
merged 6 commits into from
Oct 5, 2022
Merged

REST API to get query stages #305

merged 6 commits into from
Oct 5, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Oct 1, 2022 •
edited
Loading

Which issue does this PR close?

Closes #.

Rationale for this change

What changes are included in this PR?

New API: http://localhost:3000/api/job/{job_id}/stages

Sample Output

"stages": [
        {
            "stage_id": "8",
            "stage_status": "Completed",
            "input_rows": 215999957,
            "output_rows": 861857058,
            "elapsed_compute": "369.557711101s"
        },
        {
            "stage_id": "4",
            "stage_status": "Completed",
            "input_rows": 264,
            "output_rows": 2447,
            "elapsed_compute": "32.492879ms"
        },
        {
            "stage_id": "3",
            "stage_status": "Completed",
            "input_rows": 215999957,
            "output_rows": 861857058,
            "elapsed_compute": "361.522304348s"
        },

Are there any user-facing changes?

@andygrove andygrove marked this pull request as draft October 1, 2022 17:55
@andygrove andygrove marked this pull request as ready for review October 1, 2022 18:20
@andygrove andygrove mentioned this pull request Oct 1, 2022
Closed
avantgardnerio
avantgardnerio approved these changes Oct 3, 2022
View reviewed changes
ballista/rust/scheduler/src/api/handlers.rs
.stages()
.iter()
.map(|(id, stage)| {
let mut summary = QueryStageSummary {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like more code that could be moved into the various ExecutionStage structs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. There is probably room for quite a bit of refactoring here.

@andygrove andygrove merged commit aae3f3c into apache:master Oct 5, 2022
@andygrove andygrove deleted the rest-api-get-query-stages branch October 5, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avantgardnerio avantgardnerio avantgardnerio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andygrove @avantgardnerio