Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace function from_proto_binary_op from upstream #298

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Replace function from_proto_binary_op from upstream #298

merged 1 commit into from
Sep 30, 2022

Conversation

askoa
Copy link
Contributor

@askoa askoa commented Sep 30, 2022

Which issue does this PR close?

Closes #201

What changes are included in this PR?

The function from_proto_binary_op is duplicate of upstream function. This PR replaces the local function with upstream function. See the issue for more details.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less is more. Thanks @askoa

@andygrove andygrove merged commit c943e00 into apache:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported binary operator StringConcat
2 participants