Enabled download of dot files from Download icon #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @KenSuenobu. I merged this into my branch locally and tried it out. The href link is correct, and it downloads a file with the correct filename, but unfortunately, it is downloading an HTML page and not hitting the API endpoint. This seems to be because the accept header is not set to |
|
I'm open to adding another endpoint that doesn't require |
andygrove
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Thanks, @KenSuenobu! I tested this locally, and it worked perfectly. I will merge this once my PR is approved and merged.
|
@KenSuenobu CI is failing on a formatting issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #276.
Builds on #242 so we need to merge that first.
Rationale for this change
Adds an anchor link around the
GrDocumentDownloadlink from the ActionsCell to enable downloading of the DOT file generated from a job run.What changes are included in this PR?
Modifies the
ActionsCellcode inQueriesList.tsxby passing in the job ID to the ActionsCell. Anidfield had to be assigned along side to avoid duplicate keys. Additionally, added a snippet of documentation to theREADME.mdfile to indicate solutions to common problems when trying to run the server viayarn start.Are there any user-facing changes?
Only the noted change to README.md