Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LaunchMultiTask rpc interface for executor #255

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

yahoNanJing
Copy link
Contributor

Which issue does this PR close?

Closes #209.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@yahoNanJing yahoNanJing marked this pull request as draft September 20, 2022 15:24
@yahoNanJing
Copy link
Contributor Author

yahoNanJing commented Sep 20, 2022

Hi @askoa, it's a draft PR for issue #209. To make it work, we need to refine something of the ExecutionPlan to split out mutable things, like task level metrics and statistics.

@askoa
Copy link
Contributor

askoa commented Sep 20, 2022

hey @yahoNanJing. Not sure why you have tagged me in this!

Edit: Thanks for the info btw.

@yahoNanJing
Copy link
Contributor Author

Hi @askoa, I think you may be interested in this feature and can work on this PR together.

@yahoNanJing
Copy link
Contributor Author

Hi @thinkharderdev, @avantgardnerio and @andygrove, could you help review this PR?

Since the scheduler part is under big change in another PR for task error recovering, I will propose another PR for the scheduler to invoke this new added grpc interface for multiple tasks launching after that PR finishes.

@yahoNanJing yahoNanJing mentioned this pull request Sep 21, 2022
18 tasks
@askoa
Copy link
Contributor

askoa commented Sep 21, 2022

Hi @askoa, I think you may be interested in this feature and can work on this PR together.

@yahoNanJing Thanks for your response. I'll pick up issues from the github issues tab as time permits. I am working on something else now and does not have time to work on the PR at the moment.

Copy link
Contributor

@thinkharderdev thinkharderdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahoNanJing yahoNanJing merged commit 12128a3 into apache:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LaunchMultiTask rpc interface for executor
4 participants