Fix Scheduler UI in Docker image #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
|
@yahoNanJing @thinkharderdev @avantgardnerio This is ready for review. Once this is merged, I will create a PR to add a list of jobs and the ability to view job status. |
avantgardnerio
approved these changes
Sep 20, 2022
| @@ -85,7 +85,7 @@ fn with_data_server<T: AsLogicalPlan + Clone, U: 'static + AsExecutionPlan>( | |||
| pub fn get_routes<T: AsLogicalPlan + Clone, U: 'static + AsExecutionPlan>( | |||
| scheduler_server: SchedulerServer<T, U>, | |||
| ) -> BoxedFilter<(impl Reply,)> { | |||
| let routes = warp::path("state") | |||
| let routes = warp::path!("api" / "state") | |||
There was a problem hiding this comment.
overloading the / operator? Nothing to do with this PR, but not a fan after seeing abuse in C++ & C#.
There was a problem hiding this comment.
Agreed. I am just beginning to learn about the warp framework, so will see if this can be avoided as I learn more.
|
Thanks @andygrove. LGTM. Verified at my env. |
|
Thanks for the reviews @yahoNanJing and @avantgardnerio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #250
Rationale for this change
The UI now shows information!
What changes are included in this PR?
Try and proxy API requests to the scheduler process
Are there any user-facing changes?
nginx config