Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not include the ballista-cli in the member of workspace #88

Closed
liukun4515 opened this issue Jul 20, 2022 · 2 comments · Fixed by #89
Closed

Why not include the ballista-cli in the member of workspace #88

liukun4515 opened this issue Jul 20, 2022 · 2 comments · Fixed by #89
Labels
enhancement New feature or request

Comments

@liukun4515
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)

From https://github.com/apache/arrow-ballista/blob/a2c794e72f0b6e21b05bb8c05b38f68bba206a44/Cargo.toml#L27 toml file, the ballista-cli is exclude in the workspace.

Could you please explain this @andygrove ?

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@andygrove
Copy link
Member

I actually don't know why we chose to exclude DataFusion-cli and ballista-cli from the workspaces. It would seem better to me to include them.

@liukun4515
Copy link
Contributor Author

I actually don't know why we chose to exclude DataFusion-cli and ballista-cli from the workspaces. It would seem better to me to include them.

There is the context apache/datafusion#2112 for removing the cli from the toml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants