-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ballista assumes all aggregate expressions are not DISTINCT #5
Comments
Hi @andygrove Ive run in local ballista
And the result is expected
which is expected |
I checked the backtrace
sounds weird, but I didn't notice ballista modules here. |
Related: apache/datafusion#3250 |
The issue is specific to distributed mode because it is the serde that has the hard-coded value |
Is there any doc how to run ballista tests in distributed mode? perhaps its part of CI now? |
@andygrove @comphead Because
The current problem with ballista is that it does not support
I will sumit a PR for this :) |
Describe the bug
We have a hard-coded
distinct = false
parameter inballista/rust/core/src/serde/physical_plan/mod.rs
.To Reproduce
Try running a
COUNT(DISTINCT expr)
in BallistaExpected behavior
We need to include the distinct flag in the protobuf for aggregate queries and implement the appropriate serde code.
Additional context
None
The text was updated successfully, but these errors were encountered: