Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdout and file log level settings are inconsistent #385

Closed
r4ntix opened this issue Oct 18, 2022 · 1 comment · Fixed by #386
Closed

stdout and file log level settings are inconsistent #385

r4ntix opened this issue Oct 18, 2022 · 1 comment · Fixed by #386
Labels
enhancement New feature or request

Comments

@r4ntix
Copy link
Contributor

r4ntix commented Oct 18, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The current log level settings of the stdout and file are inconsistent:

  • file: via the --log-level-setting parameter
  • stdout: via the RUST_LOG env. if empty, this defaults to INFO

Describe the solution you'd like
Unified the log level configuration behavior: Use RUST_LOG env first, if empty, use the --log-level-setting parameter

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@r4ntix r4ntix added the enhancement New feature or request label Oct 18, 2022
@avantgardnerio
Copy link
Contributor

+1 for removing --log-level-setting. From a devops perspective: III. Config - Store config in the environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants