Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local shuffle reader in containerized environments #356

Closed
andygrove opened this issue Oct 15, 2022 · 2 comments · Fixed by #399
Closed

Use local shuffle reader in containerized environments #356

andygrove opened this issue Oct 15, 2022 · 2 comments · Fixed by #399
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
#347 adds a local shuffle reader. It uses the shuffle read URL to determine if a fetch is local or not. This works well when running as standalone processes but does not work so well in a containerized environment such as k8s where multiple executors could be running on the same host but in different containers.

Describe the solution you'd like
Why don't we just look on disk to see if the shuffle files exist locally

Describe alternatives you've considered
None

Additional context
See discussion at #347 (comment)

@andygrove
Copy link
Member Author

@Ted-Jiang What do you think of this idea?

@Ted-Jiang
Copy link
Member

Sounds like a better approach! 👍 I will make another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants