Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are bugs in the yarn build github misses but break our internal build #270

Closed
avantgardnerio opened this issue Sep 23, 2022 · 0 comments · Fixed by #271
Closed

There are bugs in the yarn build github misses but break our internal build #270

avantgardnerio opened this issue Sep 23, 2022 · 0 comments · Fixed by #271
Labels
bug Something isn't working

Comments

@avantgardnerio
Copy link
Contributor

avantgardnerio commented Sep 23, 2022

Describe the bug

Github actions to not yet perform the yarn build step that is now required to make a fully functioning Ballista scheduler artifact. Due to this, there are warnings that are treated as errors in CI that break S&T internal circleci but are not caught by github actions.

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

src/App.tsx
  Line 22:23:  'Query' is defined but never used        @typescript-eslint/no-unused-vars
  Line 22:30:  'QueryStatus' is defined but never used  @typescript-eslint/no-unused-vars

src/components/QueriesList.tsx
  Line 29:18:  'DateCell' is defined but never used      @typescript-eslint/no-unused-vars
  Line [31](https://github.com/apache/arrow-ballista/actions/runs/3115571940/jobs/5052601990#step:4:32):30:  'GrPowerReset' is defined but never used  @typescript-eslint/no-unused-vars


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.

To Reproduce

Set up your own CI that has yarn build.

Expected behavior

Both CIs work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant