Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlightSQL is broken and CI isn't catching it #190

Closed
avantgardnerio opened this issue Sep 5, 2022 · 1 comment · Fixed by #191
Closed

FlightSQL is broken and CI isn't catching it #190

avantgardnerio opened this issue Sep 5, 2022 · 1 comment · Fixed by #191
Labels
bug Something isn't working

Comments

@avantgardnerio
Copy link
Contributor

Describe the bug

PR #175 introduced a new feature flag for FlightSql support. Unfortunately CI was not updated to run build or tests for this feature, so it has been silently broken since then.

To Reproduce

cargo test --features flight-sql

Observe build failure.

Expected behavior

The build succeeds.
@avantgardnerio avantgardnerio added the bug Something isn't working label Sep 5, 2022
@avantgardnerio avantgardnerio mentioned this issue Sep 5, 2022
Merged
@avantgardnerio
Copy link
Contributor Author

avantgardnerio commented Sep 6, 2022 •
edited
Loading

@thinkharderdev if you have a moment, I'd appreciate 👀 - sorry, never mind, I see it's been merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CI to prevent future breaking of FlightSql sxt-partners/arrow-ballista
1 participant
@avantgardnerio