Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate pkg-config file: adbc.pc #2375

Closed
taozuhong opened this issue Dec 18, 2024 · 6 comments
Closed

Generate pkg-config file: adbc.pc #2375

taozuhong opened this issue Dec 18, 2024 · 6 comments
Labels
Type: question Usage question

Comments

@taozuhong
Copy link

What feature or improvement would you like to see?

ADBC project (C folder) will generate four pkg-config files, I think it's ncorrect, it should generate one pkg-config file: adbc.pc (or adbc-17.pc), not the adbc-driver-manager.pc, the driver's pkg-config file is not need.

image

@taozuhong taozuhong added the Type: enhancement New feature or request label Dec 18, 2024
@kou
Copy link
Member

kou commented Dec 18, 2024

We should generate separated .pc for each driver.
If we have separated .pc, users can check the driver existence by pkgconf --exists adbc-driver-postgresql.

@taozuhong
Copy link
Author

We should generate separated .pc for each driver. If we have separated .pc, users can check the driver existence by pkgconf --exists adbc-driver-postgresql.

Agreed.

@kou
Copy link
Member

kou commented Dec 18, 2024

Can we close this?

@taozuhong
Copy link
Author

How to generate the pkg-config file adbc.pc? use adbc-driver-manager.pc instead it?

@lidavidm
Copy link
Member

If you are linking to the driver manager, then use adbc-driver-manager.pc. ADBC isn't a single monolithic library so there are separate pkg-config files.

@lidavidm
Copy link
Member

lidavidm commented Feb 3, 2025

Closing, as I think this is answered - please feel free to reopen or create a new issue if you have further questions.

@lidavidm lidavidm closed this as completed Feb 3, 2025
@lidavidm lidavidm added Type: question Usage question and removed Type: enhancement New feature or request labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: question Usage question
Projects
None yet
Development

No branches or pull requests

3 participants