Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(c): adjust ADBC_EXPORT work on msys #2356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build(c): adjust ADBC_EXPORT work on msys #2356

wants to merge 1 commit into from

Conversation

taozuhong
Copy link

No description provided.

@github-actions github-actions bot modified the milestone: ADBC Libraries 16 Dec 7, 2024
@lidavidm lidavidm changed the title Fixed compile issue(New) build(c): adjust ADBC_EXPORT work on msys Dec 8, 2024
@lidavidm
Copy link
Member

lidavidm commented Dec 9, 2024

I think pre-commit needs to be run, and the R and Doxygen builds need to be adjusted to recognize the new macro name

@lidavidm
Copy link
Member

lidavidm commented Dec 9, 2024

arrow-adbc/c/apidoc/Doxyfile

Line 2268 in e6bb104

PREDEFINED = ADBC_EXPORT=

@taozuhong
Copy link
Author

I made it for testing, not yet ready, you could drop it or modify it directly. @lidavidm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeroshade zeroshade Awaiting requested review from zeroshade zeroshade is a code owner

@lidavidm lidavidm Awaiting requested review from lidavidm lidavidm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 16
Development

Successfully merging this pull request may close these issues.
2 participants
@taozuhong @lidavidm