Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WrapDB Entry for ADBC #1943

Open
WillAyd opened this issue Jun 26, 2024 · 0 comments
Open

Add WrapDB Entry for ADBC #1943

WillAyd opened this issue Jun 26, 2024 · 0 comments
Labels
Type: enhancement New feature or request

Comments

@WillAyd
Copy link
Contributor

WillAyd commented Jun 26, 2024

What feature or improvement would you like to see?

Now that #1941 has been completed, a nice follow up would be to add the ADBC drivers to the Meson WrapDB. This would give end users a very simple way to embed ADBC client sources into their own applications.

The one thing that makes ADBC different from other entries in the WrapDB is the fact that many of the components you'd want to distribute are toggled on via options, i.e. if you wanted sqlite built you have to do meson configure =Dsqlite=true

I think this means we would declare dependencies for the adbc_sqlite, adbc_postgresql, etc... and the user may have to specify things like:

adbc_sqlite_dep = dependency('adbc_sqlite', default_options: ['sqlite=true'])
adbc_postgresql_dep = dependency('adbc_postgresql', default_options: ['postgresql=true]')
...

The above idea was taken from an IRC conversation with @eli-schwartz though there may be other ways as well

@WillAyd WillAyd added the Type: enhancement New feature or request label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant