From 8d95ec8f3110ba05fc0b5cb7ef3ccfd007a856cb Mon Sep 17 00:00:00 2001 From: Joris Van den Bossche Date: Thu, 7 Dec 2023 15:14:01 +0100 Subject: [PATCH] lint --- .pre-commit-config.yaml | 12 ++++++------ .../adbc_driver_manager/adbc_driver_manager/dbapi.py | 2 +- python/adbc_driver_manager/tests/test_lowlevel.py | 4 +++- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 01e624caa0..13c17ecb77 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -59,12 +59,12 @@ repos: - "--filter=-whitespace/comments,-whitespace/indent,-readability/braces,-readability/casting,-readability/todo,-readability/alt_tokens,-build/header_guard,-build/c++11,-build/include_order,-build/include_subdir,-runtime/references" - "--linelength=90" - "--verbose=2" - - repo: https://github.com/golangci/golangci-lint - rev: v1.49.0 - hooks: - - id: golangci-lint - entry: bash -c 'cd go/adbc && golangci-lint run --fix --timeout 5m' - types_or: [go] + # - repo: https://github.com/golangci/golangci-lint + # rev: v1.49.0 + # hooks: + # - id: golangci-lint + # entry: bash -c 'cd go/adbc && golangci-lint run --fix --timeout 5m' + # types_or: [go] - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks rev: v2.3.0 hooks: diff --git a/python/adbc_driver_manager/adbc_driver_manager/dbapi.py b/python/adbc_driver_manager/adbc_driver_manager/dbapi.py index 44d10fcbf0..819cefe3c8 100644 --- a/python/adbc_driver_manager/adbc_driver_manager/dbapi.py +++ b/python/adbc_driver_manager/adbc_driver_manager/dbapi.py @@ -1165,6 +1165,6 @@ def _is_arrow_data(data): hasattr(data, "__arrow_c_array__") or hasattr(data, "__arrow_c_stream__") or isinstance( - data, (pyarrow.RecordBatch, pyarrow.Table, pyarrow.RecordBatchReader), + data, (pyarrow.RecordBatch, pyarrow.Table, pyarrow.RecordBatchReader) ) ) diff --git a/python/adbc_driver_manager/tests/test_lowlevel.py b/python/adbc_driver_manager/tests/test_lowlevel.py index 5fbc056b82..98c8721ca0 100644 --- a/python/adbc_driver_manager/tests/test_lowlevel.py +++ b/python/adbc_driver_manager/tests/test_lowlevel.py @@ -396,7 +396,9 @@ def test_child_tracking(sqlite): def test_pycapsule(sqlite): _, conn = sqlite handle = conn.get_table_types() - with pyarrow.RecordBatchReader._import_from_c_capsule(handle.__arrow_c_stream__()) as reader: + with pyarrow.RecordBatchReader._import_from_c_capsule( + handle.__arrow_c_stream__() + ) as reader: reader.read_all() # set up some data