Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want to log-rotate plugin support max_size #7724

Closed
qihaiyan opened this issue Aug 17, 2022 · 8 comments · Fixed by #7749
Closed

feat: As a user, I want to log-rotate plugin support max_size #7724

qihaiyan opened this issue Aug 17, 2022 · 8 comments · Fixed by #7749
Assignees

Comments

@qihaiyan
Copy link
Contributor

Description

The log-rotate can only split file by interval, i want to split log file by max_size.

@tzssangglass
Copy link
Member

I've been thinking about it for a while and it seems a bit of a problem? Do we have to start a timer to monitor the size of log files?

@qihaiyan
Copy link
Contributor Author

qihaiyan commented Aug 17, 2022

I've been thinking about it for a while and it seems a bit of a problem? Do we have to start a timer to monitor the size of log files?

Seems so, the unix system has a logrotate utility depending on cron, something as a timer.

@tzssangglass
Copy link
Member

Seams so, the unix system has a logrotate utility depending on cron, something as a timer.

we can use ngx.timer.every()

@qihaiyan
Copy link
Contributor Author

I can have a try to fix it. @tzssangglass

@tzssangglass
Copy link
Member

@qihaiyan assigned you, have fun.

@emperorente
Copy link

@qihaiyan any plan for this? I have the same requirement.

@qihaiyan
Copy link
Contributor Author

@qihaiyan any plan for this? I have the same requirement.

It's about to be finished in this month. @emperorente

@emperorente
Copy link

Sounds Great, I await your update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants