Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: nacos discovery config valid error when using $ in password symbol in config.yaml #6522

Closed
Fengxq2014 opened this issue Mar 7, 2022 · 5 comments · Fixed by #6567
Closed
Assignees

Comments

@Fengxq2014
Copy link

Issue description

When using $ in nacos password in config.yaml following the document from https://apisix.apache.org/docs/apisix/discovery/nacos.
At starting time the nacos report error

Environment

  • apisix version (cmd: apisix version): 2.12.1
  • OS (cmd: uname -a): linux

Steps to reproduce

  1. Config following yaml fragment in config.yaml
discovery:
  nacos:
    host:
      - "http://nacos:NOK1&(&*!#[email protected]:8848"
  1. Start apisix

Actual result

apisix start report error

Error log

[lua] init.lua:124: get_token_param(): nacos login fail:nacos NOK1&(&*!#3$%24 desc:status = 403, context: ngx.timer
[lua] init.lua:249: get_token_param error:status = 403, context: ngx.timer

Expected result

No response

@spacewander
Copy link
Member

Fixed in #6261? Will be in the 2.13.0 release.

@leslie-tsang
Copy link
Member

Please assign it to me. :)

@leslie-tsang
Copy link
Member

Fixed in #6261? Will be in the 2.13.0 release.

The schema check rules do not match character $, I will fix it.

@leslie-tsang
Copy link
Member

@Fengxq2014 Could you please check the PR #6567 , if the test case can cover your scenario.

@Fengxq2014
Copy link
Author

@lhack-jpeg Yes, thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants