Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: use the expiration timestamp in csrf plugin #6141

Closed
Baoyuantop opened this issue Jan 18, 2022 · 0 comments · Fixed by #6201
Closed

improve: use the expiration timestamp in csrf plugin #6141

Baoyuantop opened this issue Jan 18, 2022 · 0 comments · Fixed by #6201
Labels
enhancement New feature or request

Comments

@Baoyuantop
Copy link
Contributor

Just a proposal here, in the token object instead of total expiration seconds, can we use the expiration timestamp? So during the checking phase inside the check_csrf_token method, we could potentially check/prevent/[minimize the window] of replay attacks as an added benefit by figuring out if the generated cookie is long been expired or not. WDYT
Thank you. cc @spacewander

Originally posted by @bisakhmondal in #5727 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants