-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow configuring allow-headers
in grpc-web plugin
#10248
Comments
Did you check if adding the header in code solves your error? |
yes, I hard coded those headers and fixed the error. |
allow-headers
in grpc-web plugin
@RogueJin Thank for reporting. This has been marked as a feature request. This should be straight forward to implement. |
@shreemaan-abhishek Please assign it to me and I will complete it |
@tzssangglass Do you think there is something wrong with this feature? The cross-domain related functionality seems to have some conflicts with the CORS plugin. |
Current Behavior
The Access-Control-Allow-Headers is hard coded, which causes cors issue when client needs extra headers.
https://github.com/apache/apisix/blob/master/apisix/plugins/grpc-web.lua
The request from origin 'http://localhost:5245' has been blocked by CORS policy: Request header field grpc-accept-encoding is not allowed by Access-Control-Allow-Headers in preflight response.
Expected Behavior
The header could be overwritten by json, cors plugin or even the upstream api.
the easy way is by json, like this:
{
"uri": "/*",
"name": "grpcweb",
"plugins": {
"cors": {},
"grpc-web": {
"Access-Control-Allow-Headers": "grpc-accept-encoding"
}
},
"upstream_id": "479432631159620291",
"status": 1
}
Error Logs
Steps to Reproduce
Environment
apisix version
): 3.5.0uname -a
):Linux 49c5eb4d90cd 5.15.49-linuxkit-pr change: added doc of how to load plugin. #1 SMP PREEMPT Thu May 25 07:27:39 UTC 2023 aarch64 GNU/Linux
openresty -V
ornginx -V
):nginx version: openresty/1.21.4.1
built by gcc 10.2.1 20210110 (Debian 10.2.1-6)
built with OpenSSL 1.1.1s 1 Nov 2022
TLS SNI support enabled
curl http://127.0.0.1:9090/v1/server_info
):luarocks --version
):The text was updated successfully, but these errors were encountered: