-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh properties on KubernetesPodOperator when k8s fails due to token expiration #39325
Merged
eladkal
merged 8 commits into
apache:main
from
paolo-moriello:k8spodoperator-refresh-token
May 1, 2024
Merged
Refresh properties on KubernetesPodOperator when k8s fails due to token expiration #39325
eladkal
merged 8 commits into
apache:main
from
paolo-moriello:k8spodoperator-refresh-token
May 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paolo-moriello
requested review from
jedcunningham and
hussein-awala
as code owners
April 30, 2024 10:51
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Kubernetes provider related issues
labels
Apr 30, 2024
romsharon98
requested changes
Apr 30, 2024
romsharon98
approved these changes
Apr 30, 2024
amoghrajesh
reviewed
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, small nits
paolo-moriello
force-pushed
the
k8spodoperator-refresh-token
branch
from
May 1, 2024 07:17
10a4e00
to
0df823e
Compare
eladkal
approved these changes
May 1, 2024
amoghrajesh
approved these changes
May 1, 2024
romsharon98
reviewed
May 1, 2024
paolo-moriello
force-pushed
the
k8spodoperator-refresh-token
branch
from
May 1, 2024 08:08
5bf08e1
to
5567b00
Compare
romsharon98
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #32718
The
KubernetesPodOperator
caches the hook and client used to interact with K8S. This includes also thekube config
and related secret auth token. For long running jobs, the token may expire during the execution, causing the job to fail:This PR builds on top of #32719. Before adding more tests, I'd be happy to discuss this or other approaches to solve this issue.