Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAI Files & Vector Store Hooks #39248

Merged
merged 9 commits into from
May 1, 2024
Merged

OpenAI Files & Vector Store Hooks #39248

merged 9 commits into from
May 1, 2024

Conversation

nathadfield
Copy link
Collaborator

Adding a series of hook functions for OpenAI File and Vector Store endpoints.

@nathadfield nathadfield force-pushed the openai_hooks branch 5 times, most recently from b99d450 to 4c073f0 Compare April 25, 2024 12:44
@nathadfield nathadfield marked this pull request as ready for review April 25, 2024 13:28
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
@nathadfield nathadfield requested a review from Lee-W April 26, 2024 12:52
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one nitpicks. But rest looks good to me 👍

airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
tests/providers/openai/hooks/test_openai.py Outdated Show resolved Hide resolved
@nathadfield
Copy link
Collaborator Author

Any chance of a merge before the next round of providers are cut?

@Lee-W
Copy link
Member

Lee-W commented May 1, 2024

Any chance of a merge before the next round of providers are cut?

The next wave has already started. We'll probably need to wait for the next next wave, but I can merge it now.

@Lee-W Lee-W merged commit da6c2bc into apache:main May 1, 2024
96 checks passed
@nathadfield
Copy link
Collaborator Author

@Lee-W Thanks! No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants