Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix BigQueryToMsSqlOperator #39171

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Bugfix BigQueryToMsSqlOperator #39171

merged 1 commit into from
Apr 23, 2024

Conversation

moiseenkov
Copy link
Contributor

  1. fixed BigQueryToMsSqlOperator - from now on it provides a correct parameter to the MsSqlHook (mssql_conn_id instead of mysql_conn_id);
  2. added unit tests;
  3. adjusted system test so it actually performs data transfer.

@boring-cyborg boring-cyborg bot added area:providers area:system-tests provider:google Google (including GCP) related issues labels Apr 22, 2024
dirrao
dirrao approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moiseenkov moiseenkov force-pushed the bigquery_to_mssql_fix_typo branch from 14df23b to 4080d96 Compare April 23, 2024 08:09
@potiuk
Copy link
Member

potiuk commented Apr 23, 2024

One tes to fix

@moiseenkov moiseenkov force-pushed the bigquery_to_mssql_fix_typo branch from 4080d96 to c9b2a19 Compare April 23, 2024 10:24
@moiseenkov moiseenkov force-pushed the bigquery_to_mssql_fix_typo branch from c9b2a19 to 883bc0e Compare April 23, 2024 10:25
@potiuk potiuk merged commit 4ae85d7 into apache:main Apr 23, 2024
42 checks passed
@eladkal eladkal mentioned this pull request May 1, 2024
Closed
@eladkal eladkal mentioned this pull request May 12, 2024
Closed
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirrao dirrao dirrao approved these changes

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
area:providers area:system-tests provider:google Google (including GCP) related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moiseenkov @potiuk @dirrao