Fix deferrable mode for DataflowTemplatedJobStartOperator and DataflowStartFlexTemplateOperator #39018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
area:system-tests
kind:documentation
provider:google
e-galan
force-pushed
the
fix-def-mode-for-dataflow-operators
branch
3 times, most recently
from
4c1c9ed to
3921122
Compare
|
Could you please rebase and resolve conflict as well @e-galan ? 0 |
e-galan
force-pushed
the
fix-def-mode-for-dataflow-operators
branch
from
3921122 to
c0eb648
Compare
|
Don't know all the details but it seems good for review. |
Lee-W
reviewed
Apr 23, 2024
…wStartFlexTemplateOperator
e-galan
force-pushed
the
fix-def-mode-for-dataflow-operators
branch
from
c0eb648 to
3d59b64
Compare
Lee-W
approved these changes
Apr 26, 2024
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the deferrable mode for DataflowTemplatedJobStartOperator and DataflowStartFlexTemplateOperator. Previously the deferrable mode was implemented in a way that made most of the task execution run in the sync mode, and only after the execution was finished, the control was passed to the trigger, where it only checked the job status (that was by this time completed) and then immediately returned.
List of changes:
DataflowHookto be used for the deferrable mode. The methods will start a Dataflow job and then exit returning the job data.The existing hook methods are left without changes and are still used for the sync mode.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.