Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SparkSubmitOperator argument queue as yarn_queue #38852

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Rename SparkSubmitOperator argument queue as yarn_queue #38852

merged 6 commits into from
Apr 11, 2024

Conversation

pateash
Copy link
Contributor

@pateash pateash commented Apr 9, 2024 •
edited
Loading

closes: #38461
related: #35911

Description

We added a yarn queue parameter in SparkSubmitOperator in #35911,
but this parameter overrode BaseOperator value where a queue is an Airflow queue.

Proposed Fix/Solution

Renaming the argument in SparkSubmitOperator to avoid any confusion and issues going forward,
even though in Sparksubmit it's called '--queue'.

@pateash pateash changed the title 38461 applying queue with spark submit operator is ignored FIX: applying queue with spark submit operator is ignored Apr 9, 2024
@pateash pateash changed the title FIX: applying queue with spark submit operator is ignored FIX: Applying airflow queue with spark submit operator is ignored Apr 9, 2024
@pateash pateash marked this pull request as ready for review April 9, 2024 07:57
@pateash pateash mentioned this pull request Apr 9, 2024
Closed
2 tasks
eladkal
eladkal approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will highlight this change in the release notes for the provider as while it rename the parameter this is a bug fix rather than a breaking change

@eladkal
Copy link
Contributor

eladkal commented Apr 9, 2024

Tests are failing https://github.com/apache/airflow/actions/runs/8612286825/job/23601405072?pr=38852#step:7:1943

@pateash pateash force-pushed the 38461-Applying-queue-with-SparkSubmitOperator-is-ignored branch from a0bf52f to d6bf819 Compare April 9, 2024 09:06
@Lee-W Lee-W self-requested a review April 9, 2024 09:20
@pateash pateash force-pushed the 38461-Applying-queue-with-SparkSubmitOperator-is-ignored branch from d6bf819 to 218585b Compare April 11, 2024 04:31
@pateash
Copy link
Contributor Author

pateash commented Apr 11, 2024

Tests are failing https://github.com/apache/airflow/actions/runs/8612286825/job/23601405072?pr=38852#step:7:1943

Fixed

@Lee-W Lee-W changed the title FIX: Applying airflow queue with spark submit operator is ignored Rename SparkSubmitHook argument queue as yarn_queue Apr 11, 2024
@Lee-W Lee-W changed the title Rename SparkSubmitHook argument queue as yarn_queue Rename SparkSubmitOperator argument queue as yarn_queue Apr 11, 2024
@Lee-W Lee-W merged commit 9d46507 into apache:main Apr 11, 2024
41 checks passed
@pateash pateash deleted the 38461-Applying-queue-with-SparkSubmitOperator-is-ignored branch April 11, 2024 13:01
@eladkal eladkal mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladkal eladkal eladkal approved these changes

@Lee-W Lee-W Lee-W approved these changes

Assignees
No one assigned
Labels
area:providers provider:apache-spark
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Applying queue with SparkSubmitOperator is ignored from 2.6.0 onwards
3 participants
@pateash @eladkal @Lee-W