From b8b6475aa29c4cb3f752501fb7cb76c522bfa1a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20=C5=A0ediv=C3=BD?= <6774676+eumiro@users.noreply.github.com> Date: Mon, 28 Aug 2023 21:45:33 +0200 Subject: [PATCH] Refactor unneeded 'continue' jumps in setup.py --- setup.py | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/setup.py b/setup.py index 2758cf0fda26b..0e46189c337ce 100644 --- a/setup.py +++ b/setup.py @@ -610,9 +610,8 @@ def add_extras_for_all_deprecated_aliases() -> None: """ for alias, extra in EXTRAS_DEPRECATED_ALIASES.items(): dependencies = EXTRAS_DEPENDENCIES.get(extra) if extra != "" else [] - if dependencies is None: - continue - EXTRAS_DEPENDENCIES[alias] = dependencies + if dependencies is not None: + EXTRAS_DEPENDENCIES[alias] = dependencies def add_all_deprecated_provider_packages() -> None: @@ -623,9 +622,8 @@ def add_all_deprecated_provider_packages() -> None: {"kubernetes": ["apache-airflow-provider-cncf-kubernetes"]} """ for alias, provider in EXTRAS_DEPRECATED_ALIASES.items(): - if alias in EXTRAS_DEPRECATED_ALIASES_NOT_PROVIDERS: - continue - replace_extra_dependencies_with_provider_packages(alias, [provider]) + if alias not in EXTRAS_DEPRECATED_ALIASES_NOT_PROVIDERS: + replace_extra_dependencies_with_provider_packages(alias, [provider]) add_extras_for_all_deprecated_aliases() @@ -665,10 +663,9 @@ def add_all_deprecated_provider_packages() -> None: def get_all_db_dependencies() -> list[str]: _all_db_reqs: set[str] = set() for provider in ALL_DB_PROVIDERS: - if provider not in PROVIDER_DEPENDENCIES: - continue - for req in PROVIDER_DEPENDENCIES[provider][DEPS]: - _all_db_reqs.add(req) + if provider in PROVIDER_DEPENDENCIES: + for req in PROVIDER_DEPENDENCIES[provider][DEPS]: + _all_db_reqs.add(req) return list(_all_db_reqs)