Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on November 24, 2024 #44324

Closed
12 of 22 tasks
eladkal opened this issue Nov 24, 2024 · 11 comments
Closed
12 of 22 tasks

Status of testing Providers that were prepared on November 24, 2024 #44324

eladkal opened this issue Nov 24, 2024 · 11 comments
Labels
area:providers kind:meta High-level information important to the community provider:celery provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Nov 24, 2024

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

The guidelines on how to test providers can be found in

Verify providers by contributors

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider celery: 3.8.5rc1

Provider cncf.kubernetes: 10.0.1rc1

Provider google: 11.0.0rc1

Provider standard: 0.0.2rc1

All users involved in the PRs:
@amirmor1 @dimberman @hardeybisey @fredthomsen @MaksYermak @sunank200 @kunaljubce @kacpermuda @sean-rose @kaxil @olegkachur-e @moiseenkov @gopidesupavan

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Nov 24, 2024
@dosubot dosubot bot added area:providers provider:celery provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues labels Nov 24, 2024
@moiseenkov
Copy link
Contributor

Hi,
#44131 and #43953 look good

@hardeybisey
Copy link
Contributor

Hi, #44053 works as expected.

@fredthomsen
Copy link
Contributor

#42810 is good.

@kacpermuda
Copy link
Contributor

#44214 is good

@amirmor1
Copy link
Contributor

#44262 works as expected

@sean-rose
Copy link
Contributor

I verified that #44225 works.

@kunaljubce
Copy link
Contributor

kunaljubce commented Nov 27, 2024

@eladkal So I verified that #43890 works with apache-airflow>=2.10.0 -

image

However, there's an error when I do the same with apache-airflow==2.9.3 -

image

Unless I am doing something wrong, in which case please let me know, it seems that this is happening because of #41021 which seems to be linked to the airflow 2.10.0 milestone. If that's the case, maybe we should update the documentation for it on PyPi?

image

@potiuk
Copy link
Member

potiuk commented Nov 27, 2024

However, there's an error when I do the same with apache-airflow==2.9.3

Good catch. Apparently we miss compatibility class for that in "common.compat" and the sensor has no corresponding tests that would detect it in "providers/tests/standard/sensors" - the test for filesystem sensor is still in "tests/sensors" that's why our test suite did not catch it.

If that's the case, maybe we should update the documentation for it on PyPi?

Nope. We want to keep 2.8+ compatibility. We should add compatibilty StartTriggerArgs class in "common.compat" similarly to other "after 2.8" features, and import the class from there in the sensor.

I guess @eladkal - since it's not a regression and standard provider is still 0.* it's not a blocker for the release and can be fixed as a follow-up.

@eladkal
Copy link
Contributor Author

eladkal commented Nov 27, 2024

@potiuk is correct, we don't consider this as a regression as standard provider is not yet "stable".
Specifically for 2.9.x the sensor is reachable by importing from core path. The PR in question just moved it from core to providers so while it doesn't work as intended there is simple workaround for 2.9

@eladkal
Copy link
Contributor Author

eladkal commented Nov 27, 2024

@kunaljubce if you can raise a PR with a fix that would be much appreciated

@eladkal
Copy link
Contributor Author

eladkal commented Nov 27, 2024

Thank you everyone. Providers are released.

I invite everyone to help improve providers for the next release, a list of open issues can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers kind:meta High-level information important to the community provider:celery provider:cncf-kubernetes Kubernetes provider related issues provider:google Google (including GCP) related issues testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

9 participants