Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Next Run column name and tooltip is misleading #31365

Closed
1 of 2 tasks
wolfier opened this issue May 17, 2023 · 7 comments · Fixed by #31467
Closed
1 of 2 tasks

The Next Run column name and tooltip is misleading #31365

wolfier opened this issue May 17, 2023 · 7 comments · Fixed by #31467
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug

Comments

@wolfier
Copy link
Contributor

wolfier commented May 17, 2023

Description

Expected date/time of the next DAG Run, or for dataset triggered DAGs, how many datasets have been updated since the last DAG Run

"Expected date/time of the next DAG Run" to me sounds like Run After.

Should the tooltip indicate something along the lines of "start interval of the next dagrun" or maybe the header Next Run is outdated? Something like "Next Data Interval"?

On the same vein, "Last Run" is equally as confusing. The header can be "Last Data Interval" in additional to a tool tip that describe it is the data interval start of the last dagrun.

Use case/motivation

Users confused "Next Run" as when the next dagrun will be queued and ran and does not interpret it as the next dagrun's data interval start.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@wolfier wolfier added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels May 17, 2023
@bbovenzi bbovenzi added kind:bug This is a clearly a bug good first issue area:UI Related to UI/UX. For Frontend Developers. and removed good first issue kind:feature Feature Requests labels May 17, 2023
@tirkarthi
Copy link
Contributor

+1 to this. This was raised by our internal users after Airflow upgrade. The Next Run was assumed by many as the date the execution should happen though it is only data interval start and many missed the hover over part thinking it's a plain button. We modified it to show next_dagrun_create_after as more users wanted to know the next time the dag will be executed than the data interval start.

@tirkarthi
Copy link
Contributor

Prior discussion :

#17732
#21493

@hussein-awala hussein-awala removed the needs-triage label for new issues that we didn't triage yet label May 18, 2023
@amoghrajesh
Copy link
Contributor

@wolfier @hussein-awala @bbovenzi I would like to take this up if nobody is working actively towards it.
The consensus here is to re word the tooltip text, right?

@potiuk
Copy link
Member

potiuk commented May 22, 2023

Looks like. Propose in PR and then it might be fine-tuned :)

@amoghrajesh
Copy link
Contributor

@potiuk it got assigned to @wolfier. I dont think @wolfier is taking this issue up.

@Rafnel
Copy link
Contributor

Rafnel commented Aug 2, 2023

As of Airflow 2.6.3 the "Next Run" listed on the DAG page is still in the past. For example, I have a DAG that runs on the first of the month at 8PM. The next run is 2023-09-01, 20:00:00, but the DAG UI for "Next Run" show 2023-08-01, 20:00:00, which is the data_interval_start, and is in the past. Wouldn't it be more accurate for this UI component to display the data_interval_end, which is the actual datetime of the next run?

It appears the commit in #31467 just changes the tooltip text, however I believe the true change needed is to change the actual UI component to use data_interval_end instead of data_interval_start for its "Next Run". Any thoughts?

@calebAtIspot
Copy link

Agreed, UI is still confusing to a newcomer (speaking as a newcomer).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:bug This is a clearly a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants