Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Neptune hook and operators #28289

Closed
1 task done
eladkal opened this issue Dec 11, 2022 · 13 comments · Fixed by #37000
Closed
1 task done

Add AWS Neptune hook and operators #28289

eladkal opened this issue Dec 11, 2022 · 13 comments · Fixed by #37000
Assignees
Labels

Comments

@eladkal
Copy link
Contributor

eladkal commented Dec 11, 2022

Body

Neptune is a graph db offered by AWS.
boto3 endpoints can be seen here
I think for start we need the following:

NeptuneHook
NeptuneStartDbOperator
NeptuneStopDbOperator

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added provider:amazon-aws AWS/Amazon - related issues kind:feature Feature Requests good first issue labels Dec 11, 2022
@swapz-z
Copy link

swapz-z commented Dec 11, 2022

Hello @eladkal
I would love to take this up

@Taragolis
Copy link
Contributor

@swapz-z assigned to you

@ChhaSahil
Copy link

Hello @eladkal
I would also love to take this one!

@eladkal
Copy link
Contributor Author

eladkal commented Dec 14, 2022

@ChhaSahil the issue is already assigned.
Maybe you can find other issue that you like to work on? https://github.com/apache/airflow/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@eladkal
Copy link
Contributor Author

eladkal commented Dec 30, 2022

@swapz-z are you still working on the issue?

@swapz-z
Copy link

swapz-z commented Jan 1, 2023

Yes @eladkal.
Will raise a PR this week

@shubham22
Copy link

@swapz-z - are you still looking into this? Let us know if you need any help. cc: @o-nikolas

@swapz-z
Copy link

swapz-z commented Jan 25, 2023

Thanks for the patience @shubham22 @o-nikolas

I am finished with the implementation.
However, for writing tests for operators, I am not sure, how to proceed with the same, since mypy or moto is not available for neptuneDB

Your inputs on the PR and possible guidance of tests implementation is awaited
Thanks

@o-nikolas
Copy link
Contributor

Thanks for the patience @shubham22 @o-nikolas

I am finished with the implementation. However, for writing tests for operators, I am not sure, how to proceed with the same, since mypy or moto is not available for neptuneDB

Your inputs on the PR and possible guidance of tests implementation is awaited Thanks

You do not need Moto necessarily, it's a nice way to test hooks, but not strictly required. Just mock what you need to in order to test the functionality of the Operator and the Hook and then add a System Test to functionally test the Operator (which will test the hook).

You can see a recent example PR which has done this here (it's a transfer operator, but the principles are the same).
You can see more details about writing AWS system tests in this README.

@eladkal
Copy link
Contributor Author

eladkal commented Mar 8, 2023

However, for writing tests for operators, I am not sure, how to proceed with the same, since mypy or moto is not available for neptuneDB

moto 4.1.4 added Neptune coverage
http://docs.getmoto.org/en/latest/docs/services/neptune.html

@pateash
Copy link
Contributor

pateash commented Jul 9, 2023

@eladkal could you please assign this to me

@ellisms
Copy link
Contributor

ellisms commented Jan 11, 2024

I'll take this one.

@pateash
Copy link
Contributor

pateash commented Jan 11, 2024

I'll take this one.

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment