Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-44 Migrate DagFileProcessor.execute_callbacks to Internal API. #28269

Closed
mhenc opened this issue Dec 9, 2022 · 3 comments · Fixed by #28900
Closed

AIP-44 Migrate DagFileProcessor.execute_callbacks to Internal API. #28269

mhenc opened this issue Dec 9, 2022 · 3 comments · Fixed by #28900
Assignees
Labels
AIP-44 Airflow Internal API

Comments

@mhenc
Copy link
Contributor

mhenc commented Dec 9, 2022

Note that Callback execution must be still done in DagProcessor

@mhenc mhenc converted this from a draft issue Dec 9, 2022
@mhenc mhenc moved this from 🆕 New to 📋 Backlog in AIP-44 - Internal API Dec 9, 2022
@vincbeck
Copy link
Contributor

I'd like to work on this one

@mhenc mhenc moved this from 📋 Backlog to 🏗 In progress in AIP-44 - Internal API Dec 22, 2022
@vincbeck
Copy link
Contributor

I dont think the method execute_callbacks needs to be converted itself but rather the submethods _execute_task_callbacks and _execute_dag_callbacks. What do you think? The submethod manage_slas has already its own issue

@mhenc
Copy link
Contributor Author

mhenc commented Jan 11, 2023

Right, I should have been more descriptive:
The problem about this task is that executing the callback itself must be still done in the DagProcessor (not Internal API) component.
One the other hand all requests to DB must be done through Internal API. E.g. _execute_task_callbacks first read data from DB then call ti.handle_failure(which unfortunatelly also tasks session in the arguments and ameks some additional DB calls.).
This all must be untangled - even with refactoring of some methods/introducing new

@bbovenzi bbovenzi added the AIP-44 Airflow Internal API label Feb 3, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in AIP-44 - Internal API Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-44 Airflow Internal API
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants