Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

[WIP] Bundle jed TS declaration with translation module #81

Closed
wants to merge 2 commits into from
Closed

[WIP] Bundle jed TS declaration with translation module #81

wants to merge 2 commits into from

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Jan 24, 2019

🏆 Enhancements

  • Bundle TypeScript declaration for package jed with @superset-ui/translation distribution.

Considered alternatives

  • Have every package that uses @superset-ui/translation and TypeScript write a Jed declaration. -- impractical.
  • Create a complete declaration file for jed and publish to @types/jed. -- too much work for the use case at the moment.

@kristw kristw requested a review from a team as a code owner January 24, 2019 22:57
@kristw kristw changed the title Bundle jed TS declaration with translation module [WIP] Bundle jed TS declaration with translation module Jan 24, 2019
@kristw kristw added the abandoned No longer intend to address issue or finish PR label Jan 25, 2019
@kristw kristw closed this Jan 25, 2019
@kristw
Copy link
Contributor Author

kristw commented Jan 25, 2019

Replaced by #82

@kristw kristw deleted the krist--jed branch January 25, 2019 00:06
kristw added a commit that referenced this pull request Apr 17, 2020
@kristw
feat: allow legend overrides at multiple levels (#81)
034eda1 
* feat: reduce legend text size

* feat: compute legend data

* feat: support multi-level overrides for legend
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
abandoned No longer intend to address issue or finish PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kristw