Type promises

[xtinec]

🏆 Enhancements

• type rejectAfterTimeout with generics.
• fixing an import typo in tests.

[codecov]

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files          57       57           
  Lines         560      560           
  Branches       39       39           
=======================================
  Hits          556      556           
  Misses          2        2           
  Partials        2        2

Impacted Files	Coverage Δ
...et-ui-connection/src/callApi/rejectAfterTimeout.ts	100% <ø> (ø)	⬆️
...nnection/src/callApi/callApiAndParseWithTimeout.ts	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a6487...795e635. Read the comment docs.

[williaster]

LGTM! thanks for fixing the import, wonder why this didn't throw a linting error / fail the build 🤔

also what's the advantage of generics in this situation?

[xtinec]

It lets the caller of rejectAfterTimeout specify a more specific type of the value that is being promised. For example, think using it to limit the return value to string instead of Json.

I'm not sure what happened with our lint settings. Only noticed it as VSCode complained. Will take a closer look at our lint settings.