feat(legacy-plugin-chart-nvd3): add control panels #469
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/e0yrs5fh6 |
kristw
changed the title
| timeSeriesSection[1], | ||
| sections.annotations, | ||
| ], | ||
| controlOverrides: { |
There was a problem hiding this comment.
Could we apply these overrides in-place instead of having this section here?
['color_scheme', 'label_colors']
[
'color_scheme', // replace with the object and set renderTrigger to false
'label_colors'
]
There was a problem hiding this comment.
I think that's a good idea, but for now I'm just trying to move the control panels while keeping them as intact as possible to minimize the chance of breaking things.
There was a problem hiding this comment.
@kristw I'm making an internal JIRA ticket to track this, and we can go through and audit and remove (where possible) all controlOverrides. If you think it's safe enough, we can then consider removing the code that enables them, as well. We'll discuss further with you :)
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
=========================================
- Coverage 3.19% 3.19% -0.01%
=========================================
Files 152 154 +2
Lines 5252 5259 +7
Branches 280 282 +2
=========================================
Hits 168 168
- Misses 5047 5054 +7
Partials 37 37
Continue to review full report at Codecov.
|
All the ones that are actually used in superset, anyway