Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(generator-superset): add scaffolder for chart plugin #456

Merged
merged 7 commits into from
May 13, 2020
Merged

feat(generator-superset): add scaffolder for chart plugin #456

merged 7 commits into from
May 13, 2020

Conversation

kristw
Copy link
Contributor

@kristw kristw commented May 8, 2020 •
edited
Loading

🏆 Enhancements

Add yeoman generator for chart plugin

image

@kristw kristw requested a review from a team as a code owner May 8, 2020 00:25
@vercel
Copy link

vercel bot commented May 8, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2j8hy7jym
✅ Preview: https://superset-ui-git-kristw-generator.superset.now.sh

@kristw kristw added the reviewable Ready for review label May 8, 2020
@codecov
Copy link

codecov bot commented May 8, 2020 •
edited
Loading

Codecov Report

Merging #456 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   22.73%   22.73%           
=======================================
  Files         276      276           
  Lines        6672     6672           
  Branches      645      645           
=======================================
  Hits         1517     1517           
  Misses       5115     5115           
  Partials       40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356229b...e47f366. Read the comment docs.

@vercel vercel bot temporarily deployed to Preview May 8, 2020 00:42 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 00:46 Inactive
ktmud
ktmud reviewed May 13, 2020
View reviewed changes
packages/generator-superset/generators/plugin-chart/templates/src/MyChart.erb Outdated
<text x={width / 2} y={height / 2} textAnchor="middle" fontWeight="bold" fontSize="36">
Hello!
</text>
</svg>
Copy link
Contributor

@ktmud ktmud May 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be simplified, e.g. a simple div with the parameter in formData as text? People would need to delete it anyway, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. I was copy pasting from the dummy chart.

https://apache-superset.github.io/superset-ui-plugins-template/?path=/story/plugin-chart-dummy-dummychartplugin--basic

@kristw kristw force-pushed the kristw--generator branch from da5afcd to e47f366 Compare May 13, 2020 20:39
@kristw kristw merged commit f339466 into master May 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--generator branch May 13, 2020 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ktmud ktmud ktmud approved these changes

Assignees
No one assigned
Labels
reviewable Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristw @ktmud