This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Changed the default value for buildQuery to null #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 48 48
Lines 421 421
=====================================
Hits 421 421
Continue to review full report at Codecov.
|
kristw
approved these changes
Nov 20, 2018
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
* fix(legacy-preset-chart-nvd3): stacked bar charts labels * fix(legacy-preset-chart-nvd3): fix lint
stephenLYZ
referenced
this pull request
in stephenLYZ/superset-ui
Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
None
🏆 Enhancements
During the transition of adding
buildQueryto each chart, we need to have a flag to indicate ifbuildQueryis implemented.This PR is to change the default value of
buildQueryto None, so that it can be used as the flag.📜 Documentation
🐛 Bug Fix
🏠 Internal