This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(superset-ui-query): add unit tests for #387 #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2w4prjcpr |
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 26.31% 26.33% +0.01%
==========================================
Files 192 192
Lines 5293 5293
Branches 475 475
==========================================
+ Hits 1393 1394 +1
Misses 3864 3864
+ Partials 36 35 -1
Continue to review full report at Codecov.
|
kristw
approved these changes
Apr 27, 2020
kristw
reviewed
Apr 27, 2020
| @@ -1,6 +1,6 @@ | |||
| import { buildQueryContext } from '../src'; | |||
|
|
|||
| describe('queryContextBuilder', () => { | |||
| describe('buildQueryContect', () => { | |||
ktmud
force-pushed
the
fix-test-coverage
branch
from
57c0734 to
ab44ee7
Compare
ktmud
force-pushed
the
fix-test-coverage
branch
from
65ee9e1 to
48c5f74
Compare
ktmud
force-pushed
the
fix-test-coverage
branch
from
48c5f74 to
754e3bc
Compare
|
Thanks for the unit tests! Sorry I didn't add them back when fixing this... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Add unit tests for #387, increase test coverage for core packages back to 100%.
cc @etr2460 @williaster @kristw @villebro