feat: style package for theming and styled components #362
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/superset/superset-ui/rcx4u5ymb |
Codecov Report
@@ Coverage Diff @@
## master #362 +/- ##
===========================================
- Coverage 91.67% 52.01% -39.66%
===========================================
Files 118 123 +5
Lines 1489 2653 +1164
Branches 388 394 +6
===========================================
+ Hits 1365 1380 +15
- Misses 95 1244 +1149
Partials 29 29
Continue to review full report at Codecov.
|
| @@ -0,0 +1,31 @@ | |||
| { | |||
| "name": "style", | |||
There was a problem hiding this comment.
"name": "@superset-ui/style"There was a problem hiding this comment.
oops, thanks for catching that 😐
packages/superset-ui-style/yarn.lock
Outdated
| @@ -0,0 +1,368 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
please remove this file. we only check in the yarn.lock at root level
| "superset" | ||
| ], | ||
| "scripts": { | ||
| "test": "echo \"Error: run tests from root\" && exit 1" |
There was a problem hiding this comment.
please add simple unit test to maintain 100% test coverage for core package.
packages/superset-ui-style/README.md
Outdated
| @@ -0,0 +1,26 @@ | |||
| # `style` | |||
There was a problem hiding this comment.
README for the other packages have npm and david badges on top. Would be nice to keep the same format.
| "author": "Aaron Suddjian <[email protected]>", | ||
| "homepage": "https://github.com/apache-superset/superset-ui#readme", | ||
| "license": "Apache-2.0", | ||
| "main": "lib/index.js", |
There was a problem hiding this comment.
Add
"sideEffects": false,
for more effective tree-shaking
packages/superset-ui-style/README.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # `style` | |||
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 24.9.1 to 25.1.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Signed-off-by: dependabot-preview[bot] <[email protected]>
💔 Breaking Changes
🏆 Enhancements
Adds a new package. For now the package contents are just porting the theme from Superset. This is so it can be used by viz plugins and other superset-ui components.
📜 Documentation
See readme
🐛 Bug Fix
🏠 Internal