This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Make CategoricalColorScale instance a function and remove .toFunction() #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
force-pushed
the
kristw--color-func
branch
from
ac794a7 to
1eb7522
Compare
kristw
changed the title
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 41 42 +1
Lines 345 344 -1
=====================================
- Hits 345 344 -1
Continue to review full report at Codecov.
|
williaster
reviewed
Nov 16, 2018
| * Ensure value is a string | ||
| * @param {any} value | ||
| */ | ||
| export default function cleanValue(value) { |
There was a problem hiding this comment.
could we possibly make this have a more specific name? clean is pretty generic, something like stringyifyAndTrim would make it more readable/clear what exactly "clean" means.
williaster
approved these changes
Nov 16, 2018
kristw
added
#enhancement
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancement
Feat: Use the recently added
ExtensibleFunctionto make an instance ofCategoricalColorScalebe a function itself rather than having to call.toFunction()to convert it into a color function.💔 Breaking Changes
BREAKING CHANGE: Remove
categoricalColorScale.toFunction().BREAKING CHANGE: The color scale no longer convert input to lowercase before finding color.
🐛 Bug Fix
Fix: Also apply
cleanValuebefore setting color viasetColor(value, color)in both color scale and color namespace levels.